[3.x] Improve PHP 8.4+ support by avoiding implicitly nullable types#177
Merged
WyriHaximus merged 1 commit intoreactphp:3.xfrom May 17, 2024
Merged
[3.x] Improve PHP 8.4+ support by avoiding implicitly nullable types#177WyriHaximus merged 1 commit intoreactphp:3.xfrom
WyriHaximus merged 1 commit intoreactphp:3.xfrom
Conversation
SimonFrings
approved these changes
May 16, 2024
Member
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Makes sense, looks good to me 👍
WyriHaximus
approved these changes
May 17, 2024
clue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260.
I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs.
Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch.
Builds on top of #175, #159 and reactphp/promise#260